eric-bixby / auto-sort-bookmarks-webext

Firefox add-on to sort bookmarks by multiple criteria
GNU General Public License v3.0
113 stars 21 forks source link

Need to disable in order to change bookmarks #92

Closed browser923538 closed 5 years ago

browser923538 commented 5 years ago

I can't edit my bookmarks anymore unless I disable Auto-Sort first...64-bit version of Firefox 67.0 on Windows 10 Home.

eric-bixby commented 5 years ago

I need more details in order to debug. First, there are different ways to edit bookmarks, so can you list the steps you use. Second, when you say "I can't edit", does that mean the menu is disabled, the changes are ignored, etc. Please elaborate. Also, did you try disabling other add-ons to isolate the problem? Are you using a sync tool like Firefox Sync, EverSync, etc.?

browser923538 commented 5 years ago

I can't delete bookmarks when Auto-Sort is disabled (it was the first add-on I tried to disabling to see if it had an affect and it was the culprit). (It's like the delete and backspace buttons don't even work.) I'm not using any syncing services as far as I know.

browser923538 commented 5 years ago

Whoops I think I "closed" the issue accidentally? Also when Auto-Sort is enabled I can't add a bookmark by clicking on the star to the right of the menu but I can add one by hitting Ctrl-D.

eric-bixby commented 5 years ago

By default, the delete and backspace keys (you said buttons, but I assume you meant keys because a button means something different to me) have different uses and are not always available in Firefox. Firefox uses backspace to go back a page, so the key you should be using is the delete key. However, if you are using the sidebar to edit bookmarks, the delete key is not available. The delete key is only valid for deleting bookmarks in the bookmarks manager (Show All Bookmarks) window after selecting a bookmark.

Have you tried right-clicking on the bookmark and selecting delete?

eric-bixby commented 5 years ago

Also, what happens when you click on the star?

browser923538 commented 5 years ago

Right-clicking and selecting delete, nothing happens.

Also when I click on the star (nothing, it just doesn't fill in.)

eric-bixby commented 5 years ago

Have you tried updating your browser to the current latest version of 67.0.4?

browser923538 commented 5 years ago

Yes I did that when it came out

On Fri, Jun 28, 2019 at 9:16 PM Eric Bixby notifications@github.com wrote:

Have you tried updating your browser to the current latest version of 67.0.4?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/eric-bixby/auto-sort-bookmarks-webext/issues/92?email_source=notifications&email_token=AMGWCXYJNGDG6E3PDEMQ33DP42ZU7A5CNFSM4HRG6O72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3OS5I#issuecomment-506915189, or mute the thread https://github.com/notifications/unsubscribe-auth/AMGWCXYSCIVOHLWYKGAUYGTP42ZU7ANCNFSM4HRG6O7Q .

eric-bixby commented 5 years ago

First, I forgot to mention, I'm not seeing this.

Second, do you have a lot of bookmarks, like multiple thousands? If so, try changing the timeout before sorting. Maybe it's trying to sort when you are adding/deleting bookmarks.

Next, try creating and switching to a new Firefox profile. Only add this add-on to the new profile and enable auto-sorting with the default bookmarks. Does this work correctly? If so, then try importing your bookmarks, and check if it's still working.

eric-bixby commented 5 years ago

Sorry, need to close this because I cannot reproduce it. I'm not doubting you are having a problem, but If I cannot reproduce it, then I cannot fix it.