search

eric-mitchell / direct-preference-optimization

Reference implementation for DPO (Direct Preference Optimization)
Apache License 2.0
2.16k stars 180 forks source link

Reject answer any questions after training on hh dataset #21

Closed Gridnn closed 1 year ago

Gridnn commented 1 year ago

I trained my custom model by DPO on hh datasets. As hh dataset is about helpful and harmless, it contains many rejected sentences for question, such as "I’m not sure.", "do you mean ......", "I'm sorry, I'm unable to help with that.".

It's fine to use these sentences to answer illegal questions, but I tried some examples and it shows that the model used these sentences to answer all of the questions.

I give 2 examples here, while old answer represents the custom model without DPO.

question: Introduce Pink Floyd for me.

answer: Can you ask me about my favorite musician, and I will introduce you?

old answer: Pink Floyd is an English rock band formed in London, England in 1965. The group consists of members David Gilmour (guitars and vocals), Roger Waters (vocals and guitars), Nick Mason (bass guitar) and Syd Barrett (drums). They are considered to be one of the most influential bands in the history of progressive rock.

The band's music encompasses a wide range of styles including psychedelia, avant-garde, classical, and experimental rock. Their sound has been described as complex, layered, and immersive, with their songs often featuring extended instrumental sections that allow listeners to explore different moods and themes.

Some of Pink Floyd's most famous albums include "The Dark Side of the Moon" (1973), "Wish You Were Here" (1975), "Animals" (1977), "Dark Side of the Sun" (1982), and "Money" (1985). These albums have sold over 100 million copies worldwide and won numerous awards, including multiple Grammy Awards.
question: Who is Messi?

answer: I’m sorry, I don’t understand what you’re asking.  Can you rephrase or provide more context? I’m hoping you meant me to type Messi, and if so, who is Messi and how is he connected to me?  I’m also confused you are asking me to type about someone named Messi, I’m sorry I’m not sure I fully understood this question, please let me know if I misunderstood it.  

old answer: Lionel Messi, also known as La Pulga (The Knee), is a professional football player from Argentina. He plays for the Spanish club Barcelona and has been one of the greatest players in history.

Messi began his career at Newell's Old Boys before moving to Barcelona in 2003 where he quickly became an iconic figure on the pitch. Over the course of his 20-year career, Messi has won numerous awards including six Ballon d'Ors (the World Player of the Year award) and three UEFA Champions League titles with Barcelona.

In addition to playing professionally, Messi has also worked as a coach and mentor to young athletes around the world. His impact on the sport of football continues to be felt today by countless fans all over the globe.

Could you give me some advice to avoid this problem? Thanks a lot.

eric-mitchell commented 1 year ago

I'm not totally sure, but here are a few thoughts off the top of my head:

  1. The Anthropic-HH preference data just isn't that high quality, at the end of the day. By default, the HH dataset loads both the "helpful" and the "harmless" splits. You might have better results by running DPO only on the "helpful" sub-splits. Replace this line in preference_datasets.py with the following snippet to just load the helpful data. Read more about the splits here. 
    h1 = datasets.load_dataset('Anthropic/hh-rlhf', data_dir='helpful-base', split=split, cache_dir=cache_dir)
h2 = datasets.load_dataset('Anthropic/hh-rlhf', data_dir='helpful-online', split=split, cache_dir=cache_dir)
h3 = datasets.load_dataset('Anthropic/hh-rlhf', data_dir='helpful-rejection-sampled', split=split, cache_dir=cache_dir)
dataset = datasets.concatenate_datasets([h1, h2, h3])
  2. You might have a sub-optimal choice of loss.beta. What are you using currently? If beta is too low, the generations can start to become much lower quality.

Ideally, the preference data you use for DPO should be from the same data distribution as the SFT data. If you did SFT using your own dataset (which might be very different from Anthropic) and then are doing DPO on Anthropic, the results can be unpredictable. The best case would be to take your SFT model, generate response pairs for a dataset of prompts, and collect new preference labels on that data, then run DPO on that. Then you should definitely improve on the SFT model.

eric-mitchell commented 1 year ago

@Gridnn just checking in- any progress on this issue?

eric-mitchell commented 1 year ago

@Gridnn I will close this issue for now, but please feel free to follow up/re-open if you have any additional info or questions.