search

eric-pedersen / mixed-effect-gams

Repo for tutorial/paper on mixed-effect GAMs
MIT License
122 stars 32 forks source link

Proposed edits to section 2 #10

Closed eric-pedersen closed 6 years ago

eric-pedersen commented 6 years ago

Includes the edits suggested by David and I to Gavin's changes, as well as some broader text changes

This push request would include all of the edits that David and I suggested to Gavin's pull request from before, as well as some major changes to the body of the text.

What I've done is:

  1. tried as much to remove extraneous text. Our paper is already too long, and a lot of the things we discussed are covered in cited papers. This includes cutting the entire ti discussion, as we don't use ti() functions in any of our examples.
  2. Added a (very) brief discussion of t2 versus te tensors, as those are used, and it's important to recognize that they are different.
  3. Tried to unify the flow a bit. This meant moving the discussion on how random effects are smoothers up to where we were talking about TPRSs, and splitting tensor products into their own section.
  4. Removed old comments we had added to prior drafts.
dill commented 6 years ago

I'm happy with these changes as-is and don't see anything problematic, but obviously reserve the right to change my mind on that when I re-read in the context of the whole paper ;)