search

eric-wieser / computercraft-github

A readonly github repository client for computercraft
MIT License
27 stars 15 forks source link

Bugfix: Create directory if not exists, Feature addition: pastebin-based installer #1

Closed ogredude closed 8 years ago

ogredude commented 11 years ago

Hi,

I've been looking for a way to manage my computercraft development through github, because quite honestly the whole "copy -> paste to pastebin -> delete file on in-game computer -> type in the stupid untypeable code into the computer again" development cycle was filling me with rage.

I found your project to be the first one that reliably pulls from github. Thanks for building it! Now my workflow is so much more comfortable. Work -> Commit -> Push -> Clone. Nearly normal!

I noticed that when you clone a repo, if the destination directory doesn't already exist, it simply creates the directory and doesn't actually download anything.

I've got that fixed, it now creates the destination directory before trying to download if the destination directory doesn't exist.

I also cooked up an installer for those of us with only pastebin access to our computercraft computers. It's set to my fork of this project, you'll want to change that for yours.

ogredude commented 11 years ago

Well, first off, I'm not really sure how to operate the pull requests. I'd intended to submit separate pull requests for fixing the github downloader and for the installer. Not sure how to do that.

The main reason it's in the repository is so I don't have to rely on pastebin having it there. Worst case scenario, I copy it from the repository back to the pastebin.

eric-wieser commented 11 years ago

I think pull requests assume that you branch, and submit the branch as the pull request. I've been caught out by that before.