kill tabs with fire - Githubissues

eric-wieser / computercraft-github

A readonly github repository client for computercraft

MIT License

27 stars 15 forks source link

kill tabs with fire #10

Closed aaronmallen closed 8 years ago

aaronmallen commented 8 years ago

Fixed

converted all tabs to double space.

aaronmallen commented 8 years ago

this is literally just a find in replace for \t to no actual code was altered.

eric-wieser commented 8 years ago

Why two spaces and not four? It's a shame there's no equivalent of PEP8 for lua to give a definitive recommendation

aaronmallen commented 8 years ago

we can do four... I personally prefer 2 but its your code base mang. Just say the word and I will push again.

eric-wieser commented 8 years ago

Also, why spaces and not tabs?

The community seems pretty divided on the issue:

Tabs:

Two spaces

Olivine labs

No strong preference

http://lua-users.org/wiki/LuaStyleGuide

So I'm inclined to leave this as is?

aaronmallen commented 8 years ago

cool close the PR I'll redo the formatting on my other.

eric-wieser commented 8 years ago

Unless there's a CC-centric reason to not use tabs?

aaronmallen commented 8 years ago

nope just personal preference... tabs tend to break projects that use a Metric/LineLength rule, and are the devil in general. But it's all down to preference.

eric-wieser commented 8 years ago

"Metric/LineLength"?