search

eric-wieser / ros_numpy

Tools for converting ROS messages to and from numpy arrays
MIT License
305 stars 159 forks source link

ROS melodic release? #16

Closed v4hn closed 4 years ago

v4hn commented 5 years ago

Hi again, it seems you did not release this package into ROS melodic yet. Did you just not get around to do it yet or is there a specific reason? It would be nice to see it available there!

eric-wieser commented 5 years ago

It's been a long time since I did a ROS release. I'm not even sure I have a ROS installation around at the moment, which makes it tricky to run bloom-release.

jccurtis commented 5 years ago

@eric-wieser if that is the case, can another user obtain maintainer access so this can be a simple apt install? These tools work nicely in melodic and will likely work fine in noetic next year provided there are no modifications for python3. Thanks for awesome work!

eric-wieser commented 5 years ago

I would be open to doing that, but am not immediately sure how to - granting maintenance access on this repo will not help.

gstavrinos commented 5 years ago

I would also like to see this package in Melodic/Noetic. I am also willing to help release and/or migrate it to Python 3.

eric-wieser commented 5 years ago

@gstavrinos: If you could work out exactly what permissions you need in order to release for me, please let me know. It should be possible to use the package today in newer ros releases simply by doing a git checkout.

gstavrinos commented 5 years ago

@eric-wieser Sure, I will try to look into it in the weekend.

gstavrinos commented 5 years ago

So, after a quick look, I think I definitely need access to the ros_numpy-release repo, but also to this one, in order to do some version bumps if required by bloom.

I am also eager to help migrate the package to Python3 (thus, ROS Noetic) if any changes are needed and generally offer maintainer support.

eric-wieser commented 5 years ago

I've added you to https://github.com/eric-wieser/ros_numpy-release @gstavrinos.

Are you able to do version-bumps via pull-requests alone, or does that not work well with bloom?

gstavrinos commented 5 years ago

Hey Eric, thanks. I think it will be easier and more efficient if I have access to this repo, too. If you feel uneasy about it, I will look into the PR method you proposed.

eric-wieser commented 4 years ago

@gstavrinos: Added you as a collaborator

gstavrinos commented 4 years ago

Thank you, Eric. I will get into it asap!

marc-hanheide commented 4 years ago

@gstavrinos , did you make any progress regarding the melodic release? We'd also need it urgently, and if you don't have the resources at the moment, I can also release into another repository under https://github.com/lcas-releases if @eric-wieser doesn't want to host future releases in his repository.

gstavrinos commented 4 years ago

@marc-hanheide, to be honest, it slipped my mind. I will do my best to release it in the next couple of days.

gstavrinos commented 4 years ago

@marc-hanheide, I just made the release. We are now waiting for the PR to be accepted and the next melodic sync! Once everything goes as expected, I will close this issue.

marc-hanheide commented 4 years ago

Thanks!!

gstavrinos commented 4 years ago

https://github.com/ros/rosdistro/pull/23892

jccurtis commented 4 years ago

Thanks @gstavrinos for following up on this!

charlesyz commented 4 years ago

Are there plans for a Noetic release? There don't seem to be any required changes for Python3. I've used the source project as-is in noetic.