eric-wieser / ros_numpy

Tools for converting ROS messages to and from numpy arrays
MIT License
305 stars 159 forks source link

Add rosbag support, add CompressedImage, add geometry_msgs Stamped types #3

Closed awesomebytes closed 6 years ago

awesomebytes commented 7 years ago

Sorry about the massive amount of changes... but is all stuff I needed so...

First, as I reported in https://github.com/eric-wieser/ros_numpy/issues/2, if I tried to transform messages from directly reading from a rosbag, it fails. That is fixed (maybe not in the most elegant way, but following your style on the package).

Secondly, CompressedImage to numpy array. Not the other way around... as that would pull big dependences like OpenCV or PIL. I did my best, I don't know how to make it more generic, sorry!

Lastly, I wanted to transparently convert also XXXStamped (PointStamped, for example) to numpy array without adding extra code, so I added that too.

I added documentation on the README too.

eric-wieser commented 6 years ago

Sorry for missing this - can you split this into a separate PR for rosbags and everything else?

A quick summary of my views here:

awesomebytes commented 6 years ago

Superseeded by https://github.com/eric-wieser/ros_numpy/pull/5 & https://github.com/eric-wieser/ros_numpy/pull/6 which also fix https://github.com/eric-wieser/ros_numpy/issues/2

Closing.