Only run tests if tests are enabled

eric-wieser / ros_numpy

Tools for converting ROS messages to and from numpy arrays

MIT License

305 stars 158 forks source link

Only run tests if tests are enabled #7

Closed awesomebytes closed 6 years ago

awesomebytes commented 6 years ago

On a system where tests are not run by default ros_numpy fails to build with:

CMake Error at /home/nao/gentoo/opt/ros/kinetic/share/catkin/cmake/test/tests.cmake:18 (message):
  () is not available when tests are not enabled.  The CMake code should only
  use it inside a conditional block which checks that testing is enabled:

  if(CATKIN_ENABLE_TESTING)

    (...)

  endif()

Call Stack (most recent call first):
  CMakeLists.txt:181 (catkin_add_nosetests)

So... just following with what is suggested.

awesomebytes commented 6 years ago

Just a little bump @eric-wieser , and reminding I offered myself in the PR: https://github.com/eric-wieser/ros_numpy/pull/6 as a maintainer of the package to release new versions and so.

eric-wieser commented 6 years ago

It looks like you've found a bug upstream in ROS here too - there's supposed to be something before those ()