search

eric / metriks

An experimental library to instrument ruby
MIT License
478 stars 51 forks source link

Cleaned up selection of librato metics #19

Open JustinLove opened 12 years ago

JustinLove commented 12 years ago

I took Ryanlower's selection code, (eric/metriks#9) made the necessary checks for empty filters, and added a few tests to cover the new cases. Did a very simple extract-method to support the tests.

eric commented 12 years ago

This looks pretty sweet. Thanks!

beanieboi commented 11 years ago

hey,

what happened to the pull request? just read through the related issues and couldn't find a hint why this isn't merged yet.

how can i help to get this merged?

eric commented 10 years ago

I've recently started on a better librato reporter here: https://github.com/eric/metriks-librato_metrics

On Mon, Sep 30, 2013 at 3:55 AM, Benjamin Fritsch notifications@github.com wrote:

hey, what happened to the pull request? just read through the related issues and couldn't find a hint why this isn't merged yet.

how can i help to get this merged?

Reply to this email directly or view it on GitHub: https://github.com/eric/metriks/pull/19#issuecomment-25342979