search

eric / metriks

An experimental library to instrument ruby
MIT License
479 stars 51 forks source link

Custom percentile reporting #41

Closed bmorton closed 2 years ago

bmorton commented 11 years ago

I set out to add an option to the Librato reporter so that custom/additional percentiles could be reported. I ended up doing some refactoring for the lists of metrics supported for each metric type in various Reporters to reduce some duplication.

I added some tests I thought were helpful and added documentation where it made sense. I'd love some feedback on this, so let me know!

Thanks!

bmorton commented 11 years ago

Hmm, apparently 1.8.7 doesn't like assert_not_empty. Additionally, I started looking through some other pull requests and see that there are other pull requests similar to mine.

Have you started pulling out reporters yet? Is a better approach to pull out the LibratoMetrics reporter?

josephruscio commented 11 years ago

@bmorton I can't speak for @eric, but I think the eventual goal is to pull the Librato reporter out. We haven't had bandwidth to do that yet unfortunately and I don't know if the actual reporter interface has stabilized yet e.g. https://github.com/eric/metriks/pull/37 ?

eric commented 11 years ago

I made some progress on #37 over the weekend, but still have some unresolved issues on how I'm going to roll it out.