search

ericadamski / collaborative-edit

A collaboration package for the Atom Text Editor ( REMOVED FROM ATOM, for now, due to many errors )
MIT License
2 stars 1 forks source link

Use meaningful variable names #8

Closed Sieniawsky closed 9 years ago

Sieniawsky commented 9 years ago

A lot of the current code base uses meaningless, or cryptic variable names, such as here, which cause poor readability and maintainability. It's an acceptable compromise to increase readability at the expense of added verbosity.

ericadamski commented 9 years ago

I will let you close this one, think for the most part my variables have informative names

Sieniawsky commented 9 years ago

What about this op and op[0].d doesn't describe much.

ericadamski commented 9 years ago

@Sieniawsky this is part of the ShareJS API and I have no control over the poor naming of the variable d in op[0].d