search

ericagol / NbodyGradient.jl

N-body integrator computes derivatives with respect to initial conditions for TTVs, RV, Photodynamics & more
MIT License
23 stars 9 forks source link

Error in criterion for a transit? #17

Open ericagol opened 5 years ago

ericagol commented 5 years ago

I think that this ri variable was meant to be the sky-projected separation to see whether the transit was happening close enough on the sky to approach the stellar radius:

https://github.com/ericagol/NbodyGradient/blob/e5f53561004e9005eb251adf2590cd9f93ce7c76/src/ttv.jl#L475

ericagol commented 2 years ago

This is still an issue in the current version of the code:

https://github.com/ericagol/NbodyGradient.jl/blob/85631d64cd22125820474fc9acd8f6da2f29c78f/src/transits/timing.jl#L14

The only reason this doesn't affect the transit-finding is that usually we pass a very large value of rstar to the code.