search

ericagol / NbodyGradient.jl

N-body integrator computes derivatives with respect to initial conditions for TTVs, RV, Photodynamics & more
MIT License
20 stars 9 forks source link

Correction term with fast kicks #66

Open ericagol opened 3 years ago

ericagol commented 3 years ago

There may be an error in the code in which the 4th-order correction is not included due to bodies which are in A or A^C:

https://github.com/ericagol/NbodyGradient.jl/blob/dc5e950a38cfc390f98f189d01ed328ec4c8ceca/src/integrator/ahl21/ahl21_no_grad.jl#L69-L114

https://github.com/ericagol/NbodyGradient.jl/blob/dc5e950a38cfc390f98f189d01ed328ec4c8ceca/src/integrator/ahl21/ahl21_no_grad.jl#L116-L169

ericagol commented 3 years ago

These functions are correct. However, David Hernandez found an error in the ahl21 routine by which the drift and kickfast calls were swapped.

langfzac commented 2 years ago

Was this fixed? @ericagol

ericagol commented 2 years ago

Yes, it was.

ericagol commented 2 years ago

It might be worth tracking down which pull request fixed this before closing the issue.