ericagol / NbodyGradient.jl

N-body integrator computes derivatives with respect to initial conditions for TTVs, RV, Photodynamics & more
MIT License
20 stars 9 forks source link

Fix up initial conditions #84

Closed langfzac closed 1 year ago

langfzac commented 2 years ago
langfzac commented 1 year ago

@ericagol How should we proceed with the derivatives for the e=0 case? For now I just set anything that depends on ecosomega and esinomega 0, but that's not the correct way to handle the 1/e terms.

ericagol commented 1 year ago

@ericagol How should we proceed with the derivatives for the e=0 case? For now I just set anything that depends on ecosomega and esinomega 0, but that's not the correct way to handle the 1/e terms.

Good question @langfzac. I'll have to look into this.

ericagol commented 1 year ago

I think we decided not to address this right now, so the user will have to assume a small eccentricity for modeling circular orbits. If we do address this, a paper by András Pál (2009) could be helpful:

Pál (2009)

langfzac commented 1 year ago

@ericagol Ok, I just set the derivatives to zero for now, and made a note about it in the documentation. Unless you see any issues, I'm going to go ahead and merge.