search

ericagol / TTVFaster

First order eccentricity transit timing variations computed in Agol & Deck (2015)
MIT License
10 stars 10 forks source link

updated to Julia v1.3 #15

Closed bmlindor closed 2 years ago

ericagol commented 3 years ago

@bmlindor I like the changes you made, but I would like to preserve the C, Python & IDL versions of the code somewhere. Since this may turn into a package, maybe the TTVFaster repo should be kept as-is, and the Julia code could be moved to TTVFaster.jl? (I think @langfzac suggested this yesterday.)

bmlindor commented 2 years ago

I'm planning to close this request and just use the branch that I forked for TTVFaster.jl

ericagol commented 2 years ago

(@bmlindor When I left the second comment, I was just replying via email, so I forgot that I had left almost exactly the same comment almost a year ago!)

bmlindor commented 2 years ago

thanks for the feedback. I updated some docs on TTVFaster and finally registered it as a package. Now running a test essentially runs through the Kepler62 example and makes sure that there are values returned for the TTVs.

If you think going ahead to modify the LaplaceCoefficients module would improve the results further, let me know.

On Aug 17, 2022, at 10:08 PM, Eric Agol @.***> wrote:

@.*** https://github.com/bmlindor When I left the second comment, I was just replying via email, so I forgot that I almost exactly the same comment almost a year ago!)

— Reply to this email directly, view it on GitHub https://github.com/ericagol/TTVFaster/pull/15#issuecomment-1219043511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEW6SCLU7XQEL2FURUHOXVTVZXAMXANCNFSM5ESLA3BQ. You are receiving this because you were mentioned.

ericagol commented 2 years ago

Great! Are you planning to detach it to make it its own standalone repository? I found some info about this on stackoverflow: https://stackoverflow.com/questions/18390249/github-make-fork-an-own-project

ericagol commented 2 years ago

I can't recall what modifications we had discussed for the LaplaceCoefficients module?

bmlindor commented 2 years ago

we discussed whether implementing analytic derivatives could speed up the code. this would require computing the derivatives of the Laplace coefficients from Table 1 of Agol & Deck (2015). you also mentioned maybe seeing how the finite differences compared to the analytic method.

yes, I was looking into that. thanks for the link. detaching complete!