Only intercept preflight requests for fonts, and bonus `insert_target` configuration option

ericallam / font_assets

Helps with serving font assets with Rails 3.1

137 stars 79 forks source link

Only intercept preflight requests for fonts, and bonus `insert_target` configuration option #18

Open snikch opened 10 years ago

snikch commented 10 years ago

Sorry this is a two in one

Preflight requests are only intercepted for font assets. Makes the gem compatible with Rack::Cors or any other setup that also requires special preflight responses
Added an insert_target option so that you can choose which middleware you want font_assets to be inserted before

xevix commented 10 years ago

ericallam commented 10 years ago

Could you expand this PR to include some specs to demonstrate the features working? To run the specs all you have to do is bundle install and then bundle exec rspec spec

sandeep45 commented 10 years ago

+1 Could use some merging

ericallam commented 10 years ago

Still looking for specs to prove this works before merging.

dmur commented 10 years ago

+1, please merge -- this gem's current behavior of responding to any preflight request is really confusing.

ericallam commented 10 years ago

@dmur and @sandeep45, I can't merge this PR until there are specs proving this functionality works. It would be irresponsible of me to just merge in some code that is untested.

dmur commented 10 years ago

@ericallam Understood. I'm not a rails guy by trade or I'd write the specs myself.