search

ericallam / font_assets

Helps with serving font assets with Rails 3.1
137 stars 79 forks source link

woff2 not delivered as wished #37

Closed Hungor closed 8 years ago

Hungor commented 9 years ago

Using the lastest fontawesome gem for rails. Woff is being intepreted well, while woff2 isn't

➜ ~ curl -I http://0.0.0.0:3000/assets/fontawesome-webfont.woff2\?v\=4.3.0 14:08 HTTP/1.1 200 OK Content-Type: application/octet-stream Content-Length: 56780 Cache-Control: public, must-revalidate Last-Modified: Fri, 20 Feb 2015 10:55:24 GMT Etag: "2033872ef56f00d4a1198108e9df3a6c" X-Request-Id: 42b2f28b-dd51-40a7-9726-4c6166255ee5 X-Runtime: 0.133566 Server: WEBrick/1.3.1 (Ruby/2.1.2/2014-05-08) Date: Tue, 10 Mar 2015 13:08:04 GMT Connection: Keep-Alive

➜ ~ curl -I http://0.0.0.0:3000/assets/fontawesome-webfont.woff\?v\=4.3.0 14:08 HTTP/1.1 200 OK Content-Type: application/font-woff Content-Length: 71508 Cache-Control: public, must-revalidate Last-Modified: Fri, 20 Feb 2015 10:55:24 GMT Etag: "4668a014139cd2748ada18c2d56c4692" X-Request-Id: e6ea3167-68fa-4b6c-b6bb-88c7b798b5e6 X-Runtime: 0.021981 Access-Control-Allow-Origin: * Access-Control-Allow-Methods: GET Access-Control-Allow-Headers: x-requested-with Access-Control-Max-Age: 3628800 Server: WEBrick/1.3.1 (Ruby/2.1.2/2014-05-08) Date: Tue, 10 Mar 2015 13:12:26 GMT Connection: Keep-Alive

skalb commented 9 years ago

FYI: looks like this was fixed in master

jjb commented 9 years ago

yep, fixed in master: https://github.com/ericallam/font_assets/pull/33/files

@ericallam - time for a minor version release? (not to presume that you have time to do that :-D thanks so much for this gem!!!)

Leooo commented 9 years ago

+1 for a new version release: buggy behaviour of bundle prevents updating the gem to the last commit

cmalpeli commented 9 years ago

+1 seeing this as well.

michaelwalters commented 9 years ago

+1 seeing this as well.

mepster commented 9 years ago

In the meantime you can include the gem like this: gem 'font_assets', github: 'ericallam/font_assets', ref: '457dcfddc4318e83679e9a0935612924b7717085'

... that commit has the woff2 support.

Hungor commented 9 years ago

mepster, yes the fix works. I hope it will be included soon.

Hungor commented 9 years ago

thanks :)

thromera commented 8 years ago

Just so you know, it has been merged into master. I think author can close the issue.

Commit of merge : https://github.com/ericallam/font_assets/commit/457dcfddc4318e83679e9a0935612924b7717085