ericalli / static-site-boilerplate

A better workflow for building modern static websites.
http://staticsiteboilerplate.com
MIT License
1.74k stars 163 forks source link

Video isn't being loaded during production. #41

Open elebumm opened 4 years ago

elebumm commented 4 years ago

Describe the bug I have a video in my HTML using a <video> tag. I have an mp4 file but when I do a production build, it doesn't get translated over.

To Reproduce Steps to reproduce the behavior:

  1. Insert a video tag with an mp4 file linked.
  2. Run a production build or deploy to netlify.
  3. Look at the video, it will result in a 404.

Expected behavior The video should be loaded in.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context I see that there is an attempt to load the videos over. in the loaders file.

elebumm commented 4 years ago

Here is how I solved my issue.

I first had to import the file in my scripts:

import '../images/housedrone.mp4';

Then the webpack build would add a hash to the file name which would cause it to not be read under the source of the video. So in the loaders.js file, i replaced the video section with this:

const videos = {
  test: /\.(mp4|webm)$/,
  use: [
    {
      loader: 'file-loader',
      query: {
        name: '[name].[ext]',
        outputPath: 'images/',
      },
    },
  ],
};

Now it works, but I don't know if this is the best solution, just one that works for me now.

truongoi commented 4 years ago

The mentioned

umer4ik commented 3 years ago

Updating html-loader up to the 1.3.2 version worked for me