ericberman / MyFlightbookAndroid

Android client app for MyFlightbook.com
http://myflightbook.com
GNU General Public License v3.0
21 stars 8 forks source link

RTL UI issues #238

Closed zartom closed 2 years ago

zartom commented 3 years ago

Screenshot_20210815-080820_MyFlightbook Screenshot_20210815-080834_MyFlightbook

ericberman commented 2 years ago

Can you clarify what the issues are here? In the first screenshot, it looks like the Flight Detail dropdown is misaligned, but everything else looks like it's switching from LTR to RTL correctly - am I missing anything?

Not quite sure what the issue is in the 2nd image.

zartom commented 2 years ago

In both images, the labels are on the right, and fields are on the left - look at the semicolons for example. It doesn't make much sense like this when not in an actual RTL language.

zartom commented 2 years ago

Also flight details field + "Med" text value are not aligned to any edge properly

ericberman commented 2 years ago

Gotcha thanks. Yeah it looked strange to my eye too, but this is all being done automatically by android I wasn't quite sure what the convention was for displaying English text when using a right to left region. I don't have anything to do with reversing. Play, since that's all in English, I think it's weird to have the checkboxes on the right as well. I just thought that that was the convention.

I'm going to have to do some research to figure this one out. At least on the web, things tend to be pretty smart about going right to left for Hebrew or Arabic, and left to right for Latin languages and more importantly doing it dynamically based on the actual text involved, not based on your region. And this might just be android being stupid and not recognizing that all of the text is still in English since I don't have a Hebrew translation.

ericberman commented 2 years ago
Screen Shot 2021-09-14 at 3 46 18 PM

Does this look weird or is it OK?

ericberman commented 2 years ago
So the issue is that I want to have something like this:
label control
label control

That is, the labels are all aligned horizontally with each other and the controls are all aligned horizontally with each other, and each label is vertically aligned with its associated with control (for effective and easy-to-scan) layout.

So in English, it should be LABEL Control and in Hebrew it should be (if Google Translate is doing this correctly) בקרת תוויות. I.e., lortnoC <- labeL

The issue is that in a right-to-left region, Android is (probably correctly) making the column order RTL, even though the columns contain English text due to the lack of a Hebrew (or Arabic) translation.

So in the screenshot above, I've explicitly forced the column order to be LTR. Obviously, that breaks if I ever do an RTL translation, but if I ever do that it's both easy to back out the "Force LTR" flag, which will be no longer necessary.

Thoughts?