ericberman / MyFlightbookAndroid

Android client app for MyFlightbook.com
http://myflightbook.com
GNU General Public License v3.0
20 stars 8 forks source link

WebViewer RTL UI (zoom buttons) #275

Open zartom opened 2 years ago

zartom commented 2 years ago

Screenshot_20220603-113030_MyFlightbook

ericberman commented 2 years ago

huh, wow, there are actually two good issues there. On the top note that it's refresh, forward, back, and that is correctly reversed from the English - so I think that's correct? Or should forward remain to the right of back?

But what's interesting is indeed the zoom buttons you highlighted in the image above. And what's particularly interesting is...they're automatic and system supplied. I'm not seeing anything in the docs or in the almighty google about how to control them. Will continue to investigate

zartom commented 2 years ago

AFAIK all RTL issues in android (since Android 6 or something) are solved by using "start" and "end" layout attributes instead of "left" and "right" like in the early days. Then the system decides what to do with the UI in most contexts.

ericberman commented 2 years ago

Indeed, and I'm doing start/end elsewhere. But alas, my point above: the layout for those zoom buttons is not anywhere in my code. I instantiate a (system-provided) webview, and the webview draws the zoom controls. So I don't have any place to put "start" or "end." I looked through the docs and can't find any way to control those; the webview just shows/hides them automatically.

Are the top toolbar buttons (refresh/forward/back) "correct" in the sense of being logical for rtl? Those are doing start/end (implicitly - they're just inside a linear layout and the linear layout is doing the ltr/rtl reversal)

ericberman commented 2 years ago

So anyhow, I have no idea how to solve the zoom buttons issue. That appears to be at the OS level.

ericberman commented 1 year ago

Looks like someone else did their own zoom buttons because indeed it's an android bug. https://github.com/osmdroid/osmdroid/issues/1053