ericberman / MyFlightbookWeb

The website and service for MyFlightbook
48 stars 18 forks source link

Saved search delete button launches the search #1089

Closed pballer2oo7 closed 1 year ago

pballer2oo7 commented 1 year ago

image

  1. Click the "red X" next to a saved search
  2. The search launches

Browsing back to the saved searches list shows that the search was indeed deleted but it loading the search initially is perhaps unexpected.

ericberman commented 1 year ago

I'm not able to reproduce this?

Here's what I do:

I wonder if what happened for you was that you still had the search active. E.g., if you omitted the "reset to show all my flights" step above (so your search results still contained the trailing 12-month flights), then deleting the saved search does not reset the active search. I.e., it's not "performing" a new search, it's just keeping all of your state. That's by design. The active search is your current context; deleting a saved query is simply affecting which search templates are in the database.

pballer2oo7 commented 1 year ago

I wonder if what happened for you was that you still had the search active.... The active search is your current context; deleting a saved query is simply affecting which search templates are in the database.

Ya thats definitely it. Makes sense to me now.