search

ericberman / MyFlightbookWeb

The website and service for MyFlightbook
49 stars 18 forks source link

Upload issue with IATA and ICAO conversion #1221

Closed RadarWarning closed 7 months ago

RadarWarning commented 7 months ago

Uploaded airport MAN, intended for Manchester airport in the UK, converted to KMAN instead of EGCC, I can see a conflict here.

https://github.com/ericberman/MyFlightbookWeb/blob/3c0df976abc473190bcd2b59972a6e64e1acef51/MyFlightbook.Web/AppCode/Places/Airports.cs#L570

ericberman commented 7 months ago

Not a bug in the code. MAN is inherently a conflict because I have both MAN and KMAN in the database, it's not due to the code you identified. KMAN is Nampa airport and MAN is the FAA identifier for the same, so the FAA and IATA identifiers are inherently in conflict.. I can re-assign to MAN if you think I should (this is why EGCC - i.e., ICAO codes - are preferrable).

ericberman commented 7 months ago

I'll go ahead and do this, the same way that PVG, which is both Shanghai and Hampton Roads (Virginia); Shanghai is clearly the busier of the two airports., so KPVG goes to Virginia and PVG goes to Shanghai.

These conflicts are inevitable with multiple naming schemes.