ericberman / MyFlightbookWeb

The website and service for MyFlightbook
49 stars 18 forks source link

Move to next/previous flight on Edit page via date #361

Closed KayRJay closed 5 years ago

KayRJay commented 5 years ago

It would be very handy if there were next/previous buttons or arrows ... < and > ... adjacent to the flight date on the edit screen. This would make it easy to browse flights to edit without having to scroll to the bottom of the page and use the new “Save and edit next/previous“ (“SENP”) feature.

Currently, as expected, changing the date does not navigate to a different flight, but actually changes the date for an existing flight. The feature proposed here is different: it does not change the date of a flight, but navigates to another flight in the same way as SNEP.

Rationale: Users can now save the changes made and move to an adjacent flight using SNEP. This is a natural thing to do after making changes. Using < or > adjacent to the date addresses a different use case, where the user has not / does not want to make changes in the displayed flight, but instead potentially wants to edit an “adjacent” flight.

Because the date is the first field displayed, no scrolling or extra mouse clicks would be required to move to a different flight from the Edit page without making any changes. Currently, to do this, the user has several choices. (1) He can scroll to the page bottom and use SENP, requiring a bit of scrolling. (2) He could return to the previous page using the browser BACK button. He then has to scroll to the desired flight to edit, hover and use the action list to “Edit this flight”. Four steps, clicking and scrolling. (3) If he returns to the list by pressing Logbook, the search context, list order and page position are lost, followed by even more scrolling and clicking.

It can be argued that the new < and > elements cause screen clutter, but there’s certainly space between the date and the adjacent field “Approaches”. The user convenience with < and > is worth a small bit of clutter. An alternative would be to put a summary of the flight above the data entry fields (like the one on the Details page). This takes more space, however.

It is possible currently to navigate between flights on the Details page without editing a flight. But once the user elects to edit a flight from the Details page, he must start over to move to a different flight he wants to edit.

ericberman commented 5 years ago

I'm going to won't-fix this, for a few reasons:

KayRJay commented 5 years ago
  1. There is already a Github issue for the pop-up warning when navigating away from a partially filled (but not committed) change. That is not a bad option. It's necessary in any case.

  2. I mentioned that it duplicates SNEP, with a bit of scrolling.

  3. I do that. The Details page does not provide the ability to actually browse for a flight to edit, choose one to edit, (yes, on the Edit page), use SNEP, and then keep browsing (without unnecessary scrolling and clicking).

  4. I understand and accept that argument. It's a cost/benefit tradeoff. To me, it's worth it, but I guess not to you.