ericberman / MyFlightbookWeb

The website and service for MyFlightbook
49 stars 18 forks source link

Add airport as locator to the Day/Night (sun angle/sunset/sunrise) feature #443

Closed KayRJay closed 4 years ago

KayRJay commented 4 years ago

The current Day/Night feature is quite nice and useful. Knowing when the sun sets at a given location surely is important when planning a flight.

As an alternative to clicking on the map, or entering the (usually not known) latitude and longitude as a locator for this feature, it would be handy to be able to enter an airport code or zip code.

There are free databases available with this information:

ericberman commented 4 years ago

Haha! See, this is why I didn't expose the playpen in the footer! ;-)

Note that you can zoom/pan the map and then click on it to fill in the lat/lon.

KayRJay commented 4 years ago

Would result in too many feature requests?

I did mention clicking on the map.

Iā€™m currently adding another feature request/issue re lat/long and zip code for other features. Sorry about that! šŸ˜€

On Jan 4, 2020, at 11:49 AM, Eric Berman notifications@github.com wrote:

Haha! See, this is why I didn't expose the playpen in the footer! ;-)

Note that you can zoom/pan the map and then click on it to fill in the lat/lon.

ā€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericberman/MyFlightbookWeb/issues/443?email_source=notifications&email_token=AEBRDEAZFCPMCE7KUHCCGBLQ4DK5BA5CNFSM4KCXK4V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIC5ZDA#issuecomment-570809484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBRDEHTJSTEZWGIQD5JUW3Q4DK5BANCNFSM4KCXK4VQ.

ericberman commented 4 years ago

Note that I have an airport database, so that's easy. As a debugging tool, the work of adding zip code support does not make sense (and besides - zip codes can cover large areas; by definition, this only works at point locations - i.e., a single latitude/longitude/time tuple.

KayRJay commented 4 years ago

I see you've closed the issue, but will you add the "easy" feature of specifying the location for the Day/Night feature by airport code?

I don't get the reference to a debugging tool. I think zip codes can be useful in several places, so see the new issue (once I submit it).

ericberman commented 4 years ago

You didn't look at the commit did you. :)

KayRJay commented 4 years ago

No ā€¦ just read the issue. I was typing my comment after your comment but before your commit! Real-time dialogue going on here. ;-)

On Jan 4, 2020, at 12:15 PM, Eric Berman notifications@github.com wrote:

You didn't look at the commit did you. :)

ā€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ericberman/MyFlightbookWeb/issues/443?email_source=notifications&email_token=AEBRDEFD2FM34WQ44GOTEODQ4DN65A5CNFSM4KCXK4V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIC6KVY#issuecomment-570811735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBRDEFNKI7K5WSHCN52FRTQ4DN65ANCNFSM4KCXK4VQ.

ericberman commented 4 years ago

Oh, the reference to debugging: the only reason I built this tool was so that I could validate my autodetection code. E.g., if I look at a GPX file or KML file with telemetry (= time-stamped series of latitude/longitude points), I can detect night flight and night landings from that. This would let me see if my autodetection code was about right.

KayRJay commented 4 years ago

Ah, so if you come to believe zip codes (and wider use of lat/long) can be useful for users, then it might make the possible feature list. I'll try to be be persuasive in my issue on this topic!

ericberman commented 4 years ago

You're going to need to be persuasive on zip codes, for a few reasons:

KayRJay commented 4 years ago

There are postal codes in most countries. Here is a free service whereyou can get lat/long from postal codes (or vice versa), in many locations world-wide. There are downloadable files containing a lot of information including postal codes, place names, elevation, lat/long, country codes, time zones, etc.

I'll explain my rationale for using zip/postal codes in the other issue.

KayRJay commented 4 years ago

Thanks for implementing this feature.

I tried the airport code, and the map doesn't get re-drawn until I "Get times". Seems it should redraw on Enter or Search.