ericberman / MyFlightbookWeb

The website and service for MyFlightbook
49 stars 18 forks source link

Periodic out of memory error on live site, requires reboot (!) #491

Closed ericberman closed 4 years ago

ericberman commented 4 years ago

Possible unmanaged memory leak?

ericberman commented 4 years ago

Or an issue with large video files being uploaded? Are we ever trying to load that into a memory stream?

ericberman commented 4 years ago

I think I've caught all of the key IDisposables that were not being disposed...closing out for now.

ericberman commented 4 years ago

Happened again yesterday. This time in CSharpDateFormatToMySQLDateFormat (which I can probably kill); I think that's a red herring.

Exception information: Exception type: OutOfMemoryException Exception message: Exception of type 'System.OutOfMemoryException' was thrown. at FindFirstChar236319(RegexRunner ) at System.Text.RegularExpressions.RegexRunner.Scan(Regex regex, String text, Int32 textbeg, Int32 textend, Int32 textstart, Int32 prevlen, Boolean quick, TimeSpan timeout) at System.Text.RegularExpressions.Regex.Run(Boolean quick, Int32 prevlen, String input, Int32 beginning, Int32 length, Int32 startat) at System.Text.RegularExpressions.Regex.Match(String input, Int32 startat) at System.Text.RegularExpressions.RegexReplacement.Replace(Regex regex, String input, Int32 count, Int32 startat) at System.Text.RegularExpressions.Regex.Replace(String input, String replacement) at System.Text.RegularExpressions.Regex.Replace(String input, String pattern, String replacement, RegexOptions options) at MyFlightbook.DBHelper.CSharpDateFormatToMySQLDateFormat(String szDateFormat) in C:\Users\ericb\Documents\logbook\MyFlightbook.Web\AppCode\Utility\DBHelper.cs:line 325 at MyFlightbook.LogbookEntryBase.QueryCommand(FlightQuery fq, Int32 offset, Int32 limit, Boolean fAsc, LoadTelemetryOption lto) in C:\Users\ericb\Documents\logbook\MyFlightbook.Web\AppCode\Flights\LogbookEntry.cs:line 1316 at MyFlightbook.LogbookEntryBase.FLoadFromDB(Int32 idRow, String szUserName, LoadTelemetryOption lto, Boolean fForceLoad, Action`1 additionalInit) in C:\Users\ericb\Documents\logbook\MyFlightbook.Web\AppCode\Flights\LogbookEntry.cs:line 1775

ericberman commented 4 years ago

I've also increased disk size and changed the VM settings to let Windows manage VM swap size; that too could have been causing this. And commit 1e98d77fedc8e39471e9c2104afa43600fe7bd65 removed localecode/shortdate, if that made a difference (which called CShapDateFormatToMySQLDateFormat in stack trace above); that code is now orphaned. I'll keep an eye out here, but for now will close.