Sceenshot has higher z-index then dropdown elements in toolbar.

ericbin1 / chrome-screen-capture

Automatically exported from code.google.com/p/chrome-screen-capture

0 stars 0 forks source link

Sceenshot has higher z-index then dropdown elements in toolbar. #287

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Take screenshot
2. Hover over Highlight element

What is the expected output?
Highlight dropdown should be visible.

What do you see instead?
Instead it is hidden by the screenshot.

What version of the product are you using? On what operating system?
5.0.5

Original issue reported on code.google.com by jeserkin@gmail.com on 30 Jan 2013 at 10:14

GoogleCodeExporter commented 9 years ago

This issue is not only with Highlight element. It regards all dropdown elements 
in header.

This is issue can be fixed if element#photo will get z-index: -1, but then 
nothing can be applied to the image. :(

Original comment by jeserkin@gmail.com on 30 Jan 2013 at 10:27

GoogleCodeExporter commented 9 years ago

Edit file showimage.css
change z-index of element#toobar to 1000 like below

.toolbar {
  position:fixed;
  height: 30px;
  margin-left: 10px;
  padding-top: 6px;
  z-index: 1000;
}

Original comment by wacha...@gmail.com on 3 Feb 2013 at 2:18

GoogleCodeExporter commented 9 years ago

after selected some dropdown elements ex. line and try to edit image you will 
notice It hightlight all image (like crlt+a) for solve this problem you have to 
edit file showimage.js
.... 
188   setDivStyle: function(x, y) {
189     $(photoshop.layerId).setAttribute("style", "");
190   //$(photoshop.layerId).setAttribute("contentEditable", false);/*before*/
190     $(photoshop.layerId).setAttribute("contentEditable", true); /*after*/

...

Original comment by wacha...@gmail.com on 3 Feb 2013 at 3:02

GoogleCodeExporter commented 9 years ago

Will this also be fixed in next version?

Original comment by jeserkin@gmail.com on 3 Feb 2013 at 3:10

GoogleCodeExporter commented 9 years ago

In fact, I'm not a member of this project. I just saw your problem seem me and 
tried to fix it. Fortunately it's solved. So I think if someone of this project 
saw this,they will fix.

Original comment by wacha...@gmail.com on 3 Feb 2013 at 3:35

GoogleCodeExporter commented 9 years ago

Awesome. Thank you. Will hope, they will.

Original comment by jeserkin@gmail.com on 3 Feb 2013 at 3:36

GoogleCodeExporter commented 9 years ago

Script doesn't solve problem described, because ("contentEditable", true) will 
cause editing in Highlight area.

Original comment by jeserkin@gmail.com on 3 Feb 2013 at 7:14

GoogleCodeExporter commented 9 years ago

maybe do like this:
.....
  setDivStyle: function(x, y) {
    $(photoshop.layerId).setAttribute("style", "");
    $(photoshop.layerId).setAttribute("contentEditable", true); // setting for all
    switch(photoshop.flag) {
      case 'rectangle':
      case 'radiusRectangle':
      case 'ellipse':
        photoshop.setHighLightMode();
        break;
      case 'redact':
        photoshop.setBlackoutMode();
        break;
      case 'text':
        photoshop.setTextMode(); // call
        break;
   ...
  setTextMode: function() {
   ...
    /* comment line below */
    //$(photoshop.layerId).setAttribute('contentEditable', true);
   ...

Original comment by wacha...@gmail.com on 4 Feb 2013 at 2:02