search

ericblade / mws-advanced

Javascript (node) Amazon Merchant Web Services (MWS) code with mws-simple as it's underpinnings
Apache License 2.0
41 stars 11 forks source link

consistency in idTypes #175

Open ericblade opened 4 years ago

ericblade commented 4 years ago

image

ericblade commented 4 years ago

we also have similar in condition

type MWSItemCondition =
    | 'New'
    | 'Used'
    | 'Collectible'
    | 'Refurbished'
    | 'Club';

type AdvItemCondition =
    | 'used'
    | 'new'
    | 'collectible'
    | 'refurbished'
    | 'club';

I'm pretty sure we are converting it to lowercase intentionally, and also that some Amazon APIs are inconsistent in their usage. I think when I went through all the docs to write ts-amazon-mws, I was surprised at how inconsistent either their APIs or their documentation are.