search

ericblade / quagga2

An advanced barcode-scanner written in Javascript and TypeScript - Continuation from https://github.com/serratus/quaggajs
MIT License
758 stars 85 forks source link

Installation description is out of date #386

Closed attikov closed 3 years ago

attikov commented 3 years ago

Links are broken, folders are missing (dist) etc... The installation part from the readme is useless.

github-actions[bot] commented 3 years ago

Thank you for filing an issue! Please be patient. :-)

ericblade commented 3 years ago

No, they're not, and no it's not.

If you have an issue with a specific link, please elaborate, but all the external links I see work. And the install part is basically just "use npm".

attikov commented 3 years ago

Ok,

Why would you check only the external links? Strange. Anyway, here it is:

"You can get the quagga.js file in the following ways: By installing the npm module and copying the quagga.js file from the dist folder."

installing the npm module

ericblade commented 3 years ago

Thank you for pointing to one that is. I wasn't going to go through and check every single link in the entire document, it's a pretty sizeable document. Apologies if my tone comes off harsh, I am re-reading earlier, and I don't intend to be like that :|

So, yes, if you install the npm module you'll have the dist, where you can get the quagga.js file. or you can build it yourself.

i'll update the link there...

attikov commented 3 years ago

All ok, I could also have point it out at the fist time instead of ranting. I'll try it again. thx!

ericblade commented 3 years ago

Perhaps restructuring parts of the README would be a good idea, it basically just follows the original document which is years old now. :|

I did point that back into the right repo (it looked like it was pointing at the fork that the guy who wrote the patch that came with that documentation change, instead of this one) so that one's fixed. If you notice anything else broken, pls let me know, or do a pull req. Thanks!