search

ericblade / quagga2

An advanced barcode-scanner written in Javascript and TypeScript - Continuation from https://github.com/serratus/quaggajs
MIT License
765 stars 85 forks source link

Consider removing Buffer from node code, replace with native array type #538

Open ericblade opened 6 months ago

ericblade commented 6 months ago

More info: https://sindresorhus.com/blog/goodbye-nodejs-buffer

Also would provide a better fix for: https://github.com/ericblade/quagga2/issues/509

The current fix is just to install the type, because it doesn't matter... but it could matter in user code.

yogeshgadge commented 6 months ago

added PR https://github.com/ericblade/quagga2/pull/539

yogeshgadge commented 6 months ago

side observations: root tsconfig.json has types ["mocha", "node"] probably consider tsconfig.test.json for the mocha tests inside src/

ericblade commented 6 months ago

good idea. there's been some recent upgrades to typescript's handling of nested tsconfig files, too, an update to current ts is probably a good idea too