Open ericchu94 opened 9 years ago
@ericchu94 should I be reviewing BRD.md?
@allenh you will get to review it soon
@ericchu94 so what should I do for this issue since it depends on gh-5 and it's not fully done yet?
Wait for gh-5 to finish. Make sure you understand gh-5
Why are you working on this issue? I mentioned above:
Wait for gh-5 to finish.
If you think gh-5 is not finished until the issue is closed and the branch is merged.
@ericchu94 ok, then I will take down the branch
@allenh please note that although this project is voluntary, there still are people depending on you and you still belong in a team. Your fellow team members are not mind readers, and have schedules of their own. We do not know the status of issues unless it is reported, and we do not know if a member is blocked unless they say so.
It is very important that the team is update to date and in sync, so that we can continue with this project. Everyone knows that if the project is proceeding too slowly, it will be abandoned. It is as simple as Rui's status update on #7 to provide some context, and should take less than 5 minutes.
Please provide a status update on this ticket, and state whether there is something blocking you, and a time estimation.
Also, please improve your quality of work. By reviewing the documentation and communicating with the team. Thanks.
@ericchu94 Sorry I have been busy for the past week. I will be able to get to the project very shortly.
@allenh, once again your quality of work is abysmal. You need to learn to read. I am tired of telling you the same thing over and over again.
Please provide a status update on this ticket, and state whether there is something blocking you, and a time estimation.
@ericchu94: The current status for this issue is currently in progress. The estimated completion time for finishing the document and having it to undergo review will be within 1 week. Sorry about the prolonged delay and miscommunication.
@FlipEnergy Please review
What are modules used in this document
just add a question mark (?)
2.
In module 1:
The system shall associate each message with a timestamp at the time the message is sent in terms of the server time.
Is it possible for the timestamp to be based on each person's local time?
3.
In module 3 under user interface:
A dropdown menu beside each contact to perform additional functions such as start chat, add to faviourite or remove
typo on favorite
That seems to everything.
@FlipEnergy
Is it possible for the timestamp to be based on each person's local time?
I think it probably will be better, if we are using a server, to use server time and time convert the server time to the user's local time just so that it's easier for the server to keep track of time. Also, if we are doing it this way then there will be a settings options on the main menu that allows the user to set local time or auto detect. What do you think?
@allenh @FlipEnergy @r29sun I am taking over this ticket; the progress is simply unacceptable. I will remember to assign @allenh easy tickets that aren't critical and won't block a lot of other issues.
@FlipEnergy please review module 1, and the added note on Data Format
@ericchu94 Everything is pretty easy to understand and seems to cover everything.
I'm just not sure what is meant by "focus and clear the message text" in the fourth point under Events.
I don't think I can reword it any better, but basically, text exists in the control even after you press enter. You have to clear the control (textbox) manually (ie: control.innerText = ""). Focus is a term that is defined in this context: Basically, sent the control as the input element (for textboxes, pressing keys will type, etc)
@FlipEnergy if you can provide a concise rewording then please do.
@ericchu94 I think I just didn't know what focus was. Module 1 looks good to me.
@FlipEnergy please review module 2
@ericchu94 What is the username control for in the Display Messages View?
Everything looks good for Module 2.
@FlipEnergy Each message needs to display a username, and therefore needs a control to do so.
@FlipEnergy please review again as per the new requirements established in gh-8
@ericchu94 I see no problems.
Just wondering if its possible to send a welcome email to those who sign up. And perhaps add a "forgot password" on the login page or something like that. I mean why else do we need their email other than as a login field?
If you think a welcome email is a good idea, then create an issue addressing that in the brd. I don't think it is needed, so I'd prioritize that pretty low.
However, I do think that the forgot password feature is a bit more important, but considering the scope of handling emails (I assume it'll be email reset passwords), I think we can simply add that in at the end.
Regardless, you should create the respective issues if you feel it is needed, so we can track these problems.
@r29sun can you review module 1 and module 2, so that you can get a head start planning the ui.
@ericchu94 module 1 and 2 reviewed.
@r29sun Please note the review section, 4th point, in our issues documentation
@FlipEnergy please review module 3
^ referenced the wrong issue by accident. Please ignore.
@ericchu94
I'm only wondering about one issue. Since this is done in a web browser, are we able use make our own right-click menu?
When a contact or an user is right-clicked on, display the custom context menu
@ericchu94 very cool. Okay, nothing else.
@ericchu94 Sorry about that, I will be more careful next time.
Depends on gh-5
Refer to gh-5 to see what should be included.