search

ericclemmons / click-to-component

Option+Click React components in your browser to instantly open the source in VS Code
MIT License
1.94k stars 75 forks source link

Hijacks default right click behavior (can't view native context menu) #39

Closed tknickman closed 2 years ago

tknickman commented 2 years ago

Describe the bug Right now this component hijacks the right click event, making the native context menu impossible to view. From the readme, it looks like this should require a modifier key as well.

This should require, or support the option to require, a modifier to open the context menu on right click

To Reproduce Steps to reproduce the behavior:

  1. Right click
  2. The click to component menu opens instead of the native context menu

Expected behavior There should be a way to view the native context menu as well (either with a modifier to show the click-to-react-component menu, or a modifier to show the native context menu.

Desktop (please complete the following information):

tknickman commented 2 years ago

I was playing with this locally and the CRA example works as expected, so this may be something specific to my setup. I'll take a deeper look and see what is going on here.

tknickman commented 2 years ago

Ah we were on 1.0.6, but this is resolved in 1.0.8. Apologies for the noise! ❤️