search

ericclemmons / click-to-component

Option+Click React components in your browser to instantly open the source in VS Code
MIT License
1.79k stars 63 forks source link

[WIP] Browser extension with Plasmo #56

Open ericclemmons opened 2 years ago

ericclemmons commented 2 years ago

Plasmo has mostly been good, but I've ran into significant storage/syncing issues between the popup.tsx and content.tsx:

https://user-images.githubusercontent.com/15182/175375096-37cc96ef-deee-4a7b-a604-112330740052.mp4

I've tried permutations of setRenderValue+setStoreValue, remove(), and everything else.

It just seems that there's a race-condition with storage. I started this ~2 weeks ago before vacation, ran into this same problem, and spent another 2 hours trouble-shooting it today.

setTimeout solves the race-condition to a degree, but I can't find a reliable number to use.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 2fdc120556799106485aa05e8d8a74b77b2c971f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR