Closed HosseinAgha closed 7 months ago
Latest commit: d62564cdc0cc9f668911389792001fb1c0a74c2a
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Will remix support be accepted? PR is already half a year old, are there any problems with this?
Also in the latest remix version (2.1.0) I get:
/node_modules/cliui/build/index.cjs:291
const stringWidth = require('string-width');
^
Error [ERR_REQUIRE_ESM]: require() of ES Module /node_modules/string-width/index.js from /node_modules/cliui/build/index.cjs not supported.
Instead change the require of index.js in /node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules.
Will remix support be accepted? PR is already half a year old, are there any problems with this?
Also in the latest remix version (2.1.0) I get:
/node_modules/cliui/build/index.cjs:291 const stringWidth = require('string-width'); ^ Error [ERR_REQUIRE_ESM]: require() of ES Module /node_modules/string-width/index.js from /node_modules/cliui/build/index.cjs not supported. Instead change the require of index.js in /node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules.
oops, I added click-to-react-component
to serverDependenciesToBundle
in remix.config.js
and everything worked.
As Remix/ESBuild
_debugSource
filepaths are relative I had to also add GaitanK's code in order to make path absolute in my Remix app.ESBuild has added _debugSource for a long time now https://github.com/evanw/esbuild/issues/2318 but looks like at least in React 18 we need to read it from somewhere else.
@ericclemmons, happy to have your feedback on this.