search

ericclemmons / grunt-angular-templates

Grunt build task to concatenate & pre-load your AngularJS templates
MIT License
710 stars 107 forks source link

Use '\n' to join the template cache entries regardless of platform #126

Closed edmorley closed 8 years ago

edmorley commented 9 years ago

Also leaves the template cache contents untouched, rather than using normalizelf().

This will ensure that developers using the same repo on different OSes will have identical grunt build output, avoiding constant churn when the built files are committed to the repository.

I've used '\n' for the joins since the rest of grunt-angular-templates uses it, as do other grunt plugins like grunt-contrib-uglify and grunt-usemin.

Fixes #125.

@ericclemmons, could you take a look? :-)

edmorley commented 9 years ago

@ericclemmons, let me know if I need to do anything else before this can be merged :-)

ericclemmons commented 9 years ago

Going to merge this, but probably bump versions because people have varying opinions on the "right" linefeed ending =/

edmorley commented 9 years ago

Ok, thank you :-)

edmorley commented 9 years ago

@ericclemmons any news on this? :-)

ericclemmons commented 9 years ago

Would you be interested in #137? I need help...

underscorebrody commented 9 years ago

@edmorley What do you think about making this optional? Based on @edmorley's comment I think it might be the best approach. Default behavior would be the current handling of line feeds, but passing in the linefeed option with your preferred linefeed string would override it. Thoughts?

edmorley commented 8 years ago

Would you be interested in #137? I need help...

Unfortunately I don't think I have the grunt expertise to help out at the moment. My team has also changed its deployment strategy, so we no longer run into this issue (the grunt build is performed on deploy instead of being committed to the repo).

If someone wants to take over the PR, they are most welcome :-)

underscorebrody commented 8 years ago

Created https://github.com/ericclemmons/grunt-angular-templates/issues/154 as an alternative to this, going to close this one.