search

ericclemmons / grunt-angular-templates

Grunt build task to concatenate & pre-load your AngularJS templates
MIT License
710 stars 107 forks source link

Extend tests #34

Closed vkammerer closed 11 years ago

vkammerer commented 11 years ago

Hello everyone,

This package is great and works fine on my end. Is there a plan to add tests for invalid templates (missing closing tags, malformed urls, etc.) and edge cases?

If yes, the package could then be used as part of the yeoman angularjs generator build process. (see https://github.com/yeoman/generator-angular/pull/277#issuecomment-21084102 )

ericclemmons commented 11 years ago

I'm going to be adding in html minification via #32. If that solution does it, then great! Otherwise, this HTML validation is outside the scope of this tool itself.

My recommendation would be to use ngtemplates when shipping your code, since it would have already been tested to work. Personally, I've yet to have bizarre markup issues that weren't obvious to solve, or somehow impaired debugability.

Keep an eye on #32!