Complete Rewrite - Githubissues

ericclemmons commented 11 years ago

This is a rewrite to allow greater customization of each part of the compiled template(s). I recommend reading the new README:

https://github.com/ericclemmons/grunt-angular-templates/tree/0.4.0

This rewrite is mostly to allow extreme customization (based on comments & PRs) of:

$templateCache ID via the url option
AMD/CommonJS/etc. support by customizing the bootstrap option
Modification of template source code (like automatically converting Jade to HTML) via the source option
Adding to or making a module via the standalone option
Support for angular.noConflict() via the angular option

Read up on the options here:

https://github.com/ericclemmons/grunt-angular-templates/tree/0.4.0#options

To make things easier, I ditched a lot of the "grunt-style" README formatting and included Examples:

https://github.com/ericclemmons/grunt-angular-templates/tree/0.4.0#examples

This PR should simplify usage and provide more flexibility without addings tons & tons of new options.

Let me know what you think, please!

mgol commented 11 years ago

@ericclemmons Thanks for a change introduced in d 398c6d1! I tested it and works fine. :) Now if you only restore the concat option I'm ready to switch. :)

ericclemmons commented 11 years ago

Oh right! I'm on it!

Eric Clemmons

On Sunday, September 8, 2013 at 11:29 PM, Michał Gołębiowski wrote:

@ericclemmons (https://github.com/ericclemmons) Thanks for a change introduced in d 398c6d1 (https://github.com/ericclemmons/grunt-angular-templates/commit/398c6d1)! I tested it and works fine. :) Now if you only restore the concat option I'm ready to switch. :)

— Reply to this email directly or view it on GitHub (https://github.com/ericclemmons/grunt-angular-templates/pull/38#issuecomment-24039709).

ericclemmons commented 11 years ago

One last time. It's too much to add the ngtemplates dest as a usemin script, right? That would cause 404s & whatnot on dev, which is why you'd want it automated...

ericclemmons commented 11 years ago

I even found a cleaner way of modifying the task!

60068aa97bb1cceb220ff27e00212e8170dbad26

mgol commented 11 years ago

Yes, that was the reason. Thanks for bringing it back! :)

I've switched to your branch in our codebase now. Just until you publish 0.4.0 on npm. :)

ericclemmons commented 11 years ago

Great! I'll merge down soon & publish...

ericclemmons commented 11 years ago

@mzgol Published 0.4.0 for ya! Thank you so much for all of the help!

ericclemmons / grunt-angular-templates

Complete Rewrite #38