search

ericclemmons / grunt-angular-templates

Grunt build task to concatenate & pre-load your AngularJS templates
MIT License
710 stars 107 forks source link

Fix path matching issue with usemin on Windows #80

Closed christianrondeau closed 10 years ago

christianrondeau commented 10 years ago

When you are working with both Windows and Linux, a common solution must be used for how path are compared with usemin:

ngtemplates: {
    dist: {
        options: {
            usemin: 'scripts' + Path.sep + 'scripts.js',
        }
    }
}

It would be better instead to normalize the path specified in the build:js section and compare with the file system result.

Note that tests were not updated because they will not run on Windows (I attempted to fix them quickly but I don't have more time to put on this at the moment)

ericclemmons commented 10 years ago

Thanks! v0.5.2 released!

christianrondeau commented 10 years ago

Wonderful! Tested on a Window 8.1 Pro machine and on Heroku successfully!

ericclemmons commented 10 years ago

::whew:: I'm glad. Thanks!