task hangs on parse error when certain letters are used

[jrencz]

in my template I have a line:

<h2 ng-model="item.description" ui-tree-keyboard-suspend</h2>

and it makes ngtamplates hang. If no --verbose is used it hangs the entire terminal window - I don't know if it's normal or not.

I checked some variations:

<h2 foo-bar="anything" foo-bar-baz</h2>

does not hang - i get: Warning: Parse Error: <h2 foo-bar="anything" foo-bar-baz</h2> Use --force to continue.

<h2 foo-bar="anything" foo-bar-suspend</h2>

takes slightly more time to execute but it finishes in second or two - i get: Warning: Parse Error: <h2 foo-bar="anything" foo-bar-suspend</h2> Use --force to continue.

<h2 foo-bar="anything" foo-keyboard-suspend</h2>

takes about 10s to execute.

the entire:

<h2 ng-model="item.description" ui-tree-keyboard-suspend</h2>

takes more than 5 minutes (I killed the process).

Seems like the longer the attribute, the more time it takes to ensure it is a parsing error. I Also checked it with or without dashes - does not seem to make much difference.

I mixed words:

<h2 ngmodel="item.description" uitreekeyboardsuspend</h2>

also takes a lot, but both

<h2 ngmodel="item.description" uitreekeyboardbar</h2>

and

<h2 ngmodel="item.description" uitreekeyfoobar</h2>

take nothing at all. Hm... suspend?

[ericclemmons]

Is it a typo that you don't have a closing tag for your <h2>?

<h2 ngmodel="item.description" uitreekeyfoobar</h2>
<!-- Missing closing tag ---------------------^-->

Besides this, do you have any htmlmin settings set?

[mgol]

@ericclemmons Please read the report again. ;) @jrencz listed cases where the unclosed tag triggers an error as it should and where it hangs the process (as it, obviously, shouldn't).

[ericclemmons]

That's why I was curious about the htmlmin config.

All previous issues with hanging has been because of that parser.

Nonetheless, I'll check this out.

[jrencz]

My setting is based on the config provided by yeoman generator-webapp my htmlmin settings are:

 {
    collapseBooleanAttributes: true,
    collapseWhitespace: true,
    removeAttributeQuotes: true,
    removeCommentsFromCDATA: true,
    removeComments: true,
    removeEmptyAttributes: true,
    removeOptionalTags: true,
    removeRedundantAttributes: true,
    useShortDoctype: true,
}

As I noticed HTML parsing error originates in html-minifier.

[ericclemmons]

Remove those settings (by setting to {}) and try again. If it then works, then it's htmlmin screwing things up (yet again)...

[jrencz]

I can confirm removing htmlmin settings fixes the issue. Will you take care of reporting it to the author or should I?

[ericclemmons]

Probably best for you to, otherwise it'll be like that thing in high school where your friend wants to break up with a girl, but asks you to tell her for him, and things get real awkward 'cause you always thought she was cool & didn't know why your friend wanted out of the relationship, but ... well, I'm kinda rambling here, but yea, it'd be best if you took care of it ;)