search

ericclemmons / grunt-angular-templates

Grunt build task to concatenate & pre-load your AngularJS templates
MIT License
710 stars 107 forks source link

"visible" attribute missing its binding expression #97

Closed josephschorr closed 10 years ago

josephschorr commented 10 years ago

When compiling an HTML template with an element with bound attribute named "visible", the minifed code is producing:

<div class="my-directive" visible>

rather than the expected:

<div class="my-directive" visible="my_bound_expression">

This breaks any code that relies on that attribute's value.

ericclemmons commented 10 years ago

Is that more if an issue with html-minifier? Try it w/o it, and if it works, it's their fault :)

josephschorr commented 10 years ago

Yeah, it looks like it is an issue with collapseBooleanAttributes. When set to false, it solves the problem. Might be a good idea to add that as a warning in the README somewhere.

Closing the issue.