Closed EvHaus closed 8 years ago
@EvNaverniouk We'll probably need to make some updates to https://github.com/ericclemmons/eslint-config-future to get this to lint, or switch to something like eslint-config-airbnb (my personal preference is of course eslint-config-pwmckenna ;) ) Anyhow, I ran this branch against a different lint config that just checks for syntactic errors and every thing looked good, so this feels ready to merge and release.
@ericclemmons this will result in ""
rather than <noscript/>
for unresolved components, which is sort of a breaking change, however its the default behavior of the react peer dependency, so how do you feel about a patch release?
@EvNaverniouk just published as 3.0.1. thanks for the PR!
This PR adds support for React 15.
Changes made:
peerDependencies
devDependencies
react-dom/server
forrenderToStaticMarkup
instead ofreact
.Resolver.js
code seems to already be usingreact-dom/server
so no changes needed to be made thereTesting:
npm run test
npm run lint
because the peerDependencies ofeslint-config-future
are not installed (resulting ineslint-config-future@2.1.1 requires a peer of babel-eslint@3.x but none was installed
errors, etc..). And I was unable to manually install the required dependencies becauseeslint-config-future
wantsbabel-eslint@3.1.x
but that version ofbabel-eslint
is broken due to this bug: https://github.com/babel/babel-eslint/issues/243 No idea of linting will pass as a result of this.