search

ericclemmons / react-resolver

Async rendering & data-fetching for universal React applications.
https://ericclemmons.github.io/react-resolver
Other
1.65k stars 52 forks source link

"react-resolver@3.1.1" has incorrect peer dependency "react@^0.14.6 || ^15.0.0-0" #132

Open janicetyp opened 6 years ago

janicetyp commented 6 years ago

I'm trying to upgrade react to v16, but there seems to be some issues with the dependencies from the latest version of react-resolver. Any ideas on how to resolve this?

pwmckenna commented 6 years ago

@janicetyp just make a pr that includes react 16 to that list, make the tests run against it, and maybe add some docs/examples if anything has to change?

didi0613 commented 6 years ago

any updates on this?

ajoshi0 commented 6 years ago

any updates on this?

ajoshi0 commented 6 years ago

@pwmckenna please check this pr: https://github.com/ericclemmons/react-resolver/pull/134 for this issue

ajoshi0 commented 6 years ago

@janicetyp any update when you will have a new release with react-16 dependency code is already merged in master in April 2018