ericclemmons / react-resolver

Async rendering & data-fetching for universal React applications.
https://ericclemmons.github.io/react-resolver
Other
1.65k stars 52 forks source link

Not all Promises are created equal #64

Closed iamdustan closed 9 years ago

iamdustan commented 9 years ago

Currently the Resolver tests that a @resolve Promise is instanceof Promise. Promises seem to be a bit fickle in that there are many different implementations and ways to get a global Promise object.

A few possibilities:

The question is should we expect one global Promise object or provide a duckpunch to interop with the different methods?

Alternatively, we could ignore Promises and use a callback which the consumer is responsible for calling in whatever async control flow implementation they should choose.

ericclemmons commented 9 years ago

This is being resolved in #65 .