search

ericclemmons / start-server-webpack-plugin

Automatically start your server once Webpack's build completes.
MIT License
158 stars 26 forks source link

Version 3.0.0-rc3 is not production ready #31

Open thesayyn opened 6 years ago

thesayyn commented 6 years ago

Today I have upgraded my plugin to a version that contains the necessary fixes such as auto restart regarding the "web pack" emit hooks, however, 3.0.0-rc3 contains a bunch of unnecessary console.log console.warn. So there's no way to remove these debugging lines and it is so itchy

thesayyn commented 6 years ago

I think there should be an option that we can suppress the logs through Something like { verbose: true | false }

wmertens commented 6 years ago

Ok, so default verbose=true, and if it's false it doesn't log anything?

thesayyn commented 6 years ago

mean there is no option to suppress logs. it shows everything by default

coreyleelarson commented 5 years ago

I agree with @thesayyn. I always try to disable any debug/info logging from libraries. The @beta version will work perfectly for my use case, but it would be nice to clean up the logging. It's not that big of a deal, but it would be nice and pretty simple to implement.

wmertens commented 5 years ago

@coreyleelarson so you never want to see any message, not when starting, reloading, crashing, nothing?

coreyleelarson commented 5 years ago

@wmertens That is correct. I manage my own server logging, and additional library logging muddies up the terminal.

wmertens commented 5 years ago

Ok, personally I always want to know if there's an error, so what do you propose for configuring logging? All/nothing or all/errors-only/nothing? And is the sswp> prefix ok or should it be different?

On Fri, Dec 7, 2018 at 4:06 PM Corey Larson notifications@github.com wrote:

@wmertens https://github.com/wmertens That is correct. I manage my own server logging, and additional library logging muddies up the terminal.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ericclemmons/start-server-webpack-plugin/issues/31#issuecomment-445260514, or mute the thread https://github.com/notifications/unsubscribe-auth/AADWlkzDC41CvGmJ0zVRZ5J1b0I12xELks5u2oP-gaJpZM4XLa5b .

coreyleelarson commented 5 years ago

All/errors-only/nothing would be great. I don't really have a preference on the prefix.