Open fivethreeo opened 4 years ago
Went with subclassing the plugin in our tests to make it silent.
I did a temporary private release just to do some testing of the webpack5 changes. Waiting eagerly for feedback. 😀If you request changes I can do them. But from what I see when using this in razzle a more silent running makes sense. So I am thinking along the lines of a info true/false or using loglevels of some kind and a worker_verbose true/false or document overriding plugin functions.
I'll try to review this week. In my changes I was trying to be quiet by default, but still output whenever there were issues that impact the user, like the build failing.
@wmertens ping 😀I am using this code successfully in razzle using a test matrix, so to works well. But could you do a alpha/beta release so I don’t have to do my own release and maybe other people can see the new release and try it out? If you want any more changes, just say and I’ll make the changes. 😀
Okay will do 😊
Wout.
On Sat., Apr. 18, 2020, 1:40 a.m. Øyvind Saltvik notifications@github.com wrote:
@wmertens https://github.com/wmertens ping 😀I am using this code successfully in razzle using a test matrix, so to works well. But could you do a alpha/beta release so I don’t have to do my own release and maybe other people can see the new release and try it out? If you want any more changes, just say and I’ll make the changes. 😀
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ericclemmons/start-server-webpack-plugin/pull/38#issuecomment-615510951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANNFSGMTWATAYZL3PUNJLRNDSG3ANCNFSM4LSXXMRA .
Might not be the best place to ask but could you add a feature to auto-restart the server when not using HMR?
Open a new issue for this, also not sure what you mean by that.
https://github.com/ericclemmons/start-server-webpack-plugin/issues/28
It just didn't seem like the original repo issues were getting updates anymore
When this PR will be merged? Webpack 5 final version just released :]
Released as razzle-start-server-webpack-plugin now, so code is now at https://github.com/jaredpalmer/razzle
Is there any progress on this? The last comment is from October
Just use razzle-start-server-webpack-plugin@canary
I used "run-script-webpack-plugin": "0.0.5" as replacement since this projet seems to be dead
It's working out just fine, I have hmr up and everything, but this should still be implemented in the original lib methinks
@wmertens: What about a silent option? Just not allow silencing since it makes little sense in dev? Maybe if verbose is false and NODE_ENV is test the server and info stays silent, but that could be a issue with other projects running tests with start-server-webpack-plugin. Alternatively subclass the plugin in our tests to make it silent?