Replaced the static methods to create a new RSAKey or SimpleKey given a JsonReader with a constructor that accepts a Map that should contain the relevant keys.
Also added two new static methods to the RSAKey class which can be used to get the exponent and modulus of an RSAKey.
Why
The constructor change is a more intuitive solution for the problem and the RSAKey static methods for the exponent/modulus might become useful in the future for distributing keys to other apps.
How
You can run the unittests to verify that all the code in data_objects is still covered so it should work correctly
Relevant Issues: -
Related Pull Requests: -
What
Replaced the static methods to create a new
RSAKeyorSimpleKeygiven aJsonReaderwith a constructor that accepts aMapthat should contain the relevant keys.Also added two new static methods to the
RSAKeyclass which can be used to get theexponentandmodulusof anRSAKey.Why
The constructor change is a more intuitive solution for the problem and the
RSAKeystatic methods for the exponent/modulus might become useful in the future for distributing keys to other apps.How
You can run the unittests to verify that all the code in
data_objectsis still covered so it should work correctlyAlternative implementation
None
Notes
None