search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Pairing button, closes #52 #114

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This PR adds a button to the right bottom corner of the MainActivity. When clicked, a menu opens with 3 buttons: bluetooth, nfc and qr.

Why

This PR is needed for this project because the user must be able to choose between the various pairing methods when we offer these.

How

This PR can be tested by clicking on the pairing button.

Alternative implementation

I checked out quite some libraries and I chose Clang's library because it was quite flexible and easy-to-use.

Notes

-

ericcornelissen commented 7 years ago

@jverbraeken Why did you change the layout of the list view in the main activity? Could you at least change the background two white (or the background of the images to gray)

Also, why waste the main button itself for closing the menu? The menu will close automatically when you click outside the menu... and even if this is not intuitive I think it will not be very common that someone accidentally clicks the menu button in which case clicking the back button (which IS intuitive) will do. I would change the button to open the menu to a usable button (e.g. the Bluetooth button) when the menu is opened.

jverbraeken commented 7 years ago

@ericcornelissen Thanks for your review! For some reason I had to run the app 3 times (?!?) before I saw what you meant with the layout of the MainActivity, was already typing an answer back that you probably made some mistake, but, anyway, something went wrong on my machine apparently.

I understand your second point and I agree with you that what you propose is nicer, but I couldn't find a library that could do that. I looked at

And apart from that I think it's much more important to put my time in functionality than design right now.

ericcornelissen commented 7 years ago

I would say you can just change the onClick event when the button is being pressed, but I might be thinking too simple there...

Anyway, I agree that you might have better things to do and this visual thing can be resolved later 😄