search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Add proper image overlay to visual verification grid #135

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

What

Adds a proper image overlay for the grid introduced in #122. Also reduced the number of buttons in the grid from 16 to 12.

Why

There should be a user friendly image on top of the buttons/grid so users can more easily identify where they clicked and specify this to the other party.

How

You can either run the Cucumber tests or change the start activity set in EntryActivity which by default is set to LoginActivity and should be changed to VisualVerificationActivity.

Alternative implementation

None considered

Notes

n/a

clenrock commented 7 years ago

I just pushed on your branch a small fix. There was an error where the contacts list was not set in the OnCreate method in the MainActivity, probably introduced while merging.

clenrock commented 7 years ago

@ericcornelissen Is it possible to add grid lines to the Activity? (Probably just a PNG with the lines and the rest transparent)