search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Make a service of QRGenerator #138

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This Pull Request adds to the repository the transfer of QRGenerator to the newly created util service

Why

This Pull Request is needed because classes that offer a platform-dependent service should be encapsulated in a service to reduce the coupling between the application and the platform

How

This feature can be viewed/tested within the project by checking if things are still working; running QRGeneratorTest

Alternative implementation

-

Notes

jverbraeken commented 7 years ago

This will most certainly lead to complications with PR #136... Maybe we should merge it into this branch to make sure to avoid having to resolve these later? Is it OK if I merge that branch into this PR?

Oops, didn't see that. I'll fix the conflicts...

jverbraeken commented 7 years ago

Oops, I think that something went wrong when I made this branch. There are far too many files changed for such a simple PR.

jverbraeken commented 7 years ago

I'll make a new branch and make a new PR for that one