Remove the hard coded password from the code base and get the password from the database. However, currently there is not yet a place for this in the database, therefor the password must equal null (not "null").
Why
Since there have been urgent requests to remove this feature.
How
You can see for yourself that the password "12345" no longer works.
Alternative implementation
It is possible to skip the LoginActivity entirely for now, which allows is to also remove the pass when no password is provided, this may be a better solution but I'd like your opinions on this...
Notes
Note that I removed the tests checking if the LoginActivity continues to the MainActivity when the correct password is provided, this is because in order to test this the database must be mocked but I have not yet been able to get this working, the branch testing/android#77 is dedicated to getting this working.
Relevant Issues: #44, #102
Related Pull Requests: -
What
Remove the hard coded password from the code base and get the password from the database. However, currently there is not yet a place for this in the database, therefor the password must equal
null(not"null").Why
Since there have been urgent requests to remove this feature.
How
You can see for yourself that the password
"12345"no longer works.Alternative implementation
It is possible to skip the
LoginActivityentirely for now, which allows is to also remove the pass when no password is provided, this may be a better solution but I'd like your opinions on this...Notes
Note that I removed the tests checking if the
LoginActivitycontinues to theMainActivitywhen the correct password is provided, this is because in order to test this the database must be mocked but I have not yet been able to get this working, the branch testing/android#77 is dedicated to getting this working.