search

ericcornelissen / NervousFish

An app for your :iphone: to exchange public-keys in a secure manner.
GNU Lesser General Public License v3.0
2 stars 4 forks source link

Pairing button, closes #52 #148

Closed jverbraeken closed 7 years ago

jverbraeken commented 7 years ago

What

This PR adds a button to the right bottom corner of the MainActivity. When clicked, a menu opens with 3 buttons: bluetooth, nfc and qr.

Why

This PR is needed for this project because the user must be able to choose between the various pairing methods when we offer these.

How

This PR can be tested by clicking on the pairing button.

Alternative implementation

I checked out quite some libraries and I chose Clang's library because it was quite flexible and easy-to-use.

Notes

This PR was closed earlier for some reason, so this is merely a copy from the old pr

TheBonheurs commented 7 years ago

For the next time: it would be nice if you could add something about the focus of reveiwing in a pr that has this many changes otherwise 💯 / 💯

jverbraeken commented 7 years ago

@TheBonheurs

For the next time: it would be nice if you could add something about the focus of reveiwing in a pr that has this many changes otherwise 💯 / 💯

No problem, will do that next time

TheBonheurs commented 7 years ago

You still have some pmd warnings 😢